z3-stack: z_importaddress smoke guard + watch-only import docs#2
Merged
Conversation
The method is gated behind the transparent-key-import cargo feature (enabled via zcashd-import in zallet/Dockerfile). Guard against a build change silently dropping it: invalid hex with a parseable account UUID must reach the feature-gated parser and answer "Invalid hex encoding", not the feature-off stub error. Params are JSON-quoted because the `zallet rpc` CLI parses each param with serde_json. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Answers the recurring migration question from zcashd importaddress / importmulti: the feature is already compiled into zero-zallet images, the method takes a hex pubkey or redeem script (not a t-address), and rescan starts from the account birthday. Also notes that help output is build-time static and proves nothing about compiled-in features. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aphelionz
force-pushed
the
z3-importaddress-guard-docs
branch
from
July 6, 2026 14:48
1572fa5 to
c854685
Compare
z_getnewaccount pins the birthday at the current chain tip, so importing an address with existing history into a fresh account finds nothing. Point readers at z_recoveraccounts and its explicit birthday_height, and JSON-quote the CLI example params. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Binance (migrating from zcashd to Zallet on the z3-stack bundle) asked whether our images need a rebuild to get
z_importaddress(upstream zallet PR #406, gated behind thetransparent-key-importcargo feature), and whetherhelp z_importaddressreturning docs proves the image has it.Findings, verified against the published
zero-zallet:latest(revision ae2d96b, pushed 2026-07-02):zallet/Dockerfilebuilds with--features rpc-cli,zcashd-import, andzcashd-importtransitively enablestransparent-key-import. Binary inspection confirms: the feature-off stub string is absent, feature-gated implementation strings are present.helpoutput is generated at build time with no cfg-gate awareness, so it lists the method regardless of features. It is not evidence either way.What
z_importaddressis genuinely compiled in. Invalid hex with a parseable account UUID deterministically reaches the feature-gated parser, which must answerInvalid hex encoding(a feature-off build answers with the stub error instead). Positive proof, no wallet-account state involved.t1...address; rescan starts from the account birthday, runs in background) and the static-help caveat.Verification
🤖 Generated with Claude Code